-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-11961 Provide comprehensive documentation for hotspots #19282
Open
florence-crl
wants to merge
14
commits into
main
Choose a base branch
from
DOC-11961
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
florence-crl
commented
Jan 15, 2025
Comment on lines
+213
to
+217
~~~ sql | ||
CREATE TABLE products ( | ||
id SERIAL PRIMARY KEY USING HASH | ||
); | ||
~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angles-n-daemons , would an example using a SEQUENCE
rather than SERIAL
be clearer? Something like:
CREATE TABLE products (
id INT PRIMARY KEY USING HASH,
name STRING
);
CREATE SEQUENCE products_id_seq;
--Insert 2 million rows
INSERT INTO products (id, name) SELECT nextval('products_id_seq'), (1000000000000000 + generate_series(1,2000000))::STRING;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-11961
Added understand-hotspots.md and corresponding images.
In sidebar-data/troubleshooting.json, added link to understand-hotspots.md.
Rendered preview: