Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search synonyms for cluster settings, session settings, MOLT #19300

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

taroface
Copy link
Contributor

The search term "session settings" isn't turning up the Session Variables page. Since "session settings" and "session variables" are sometimes used interchangeably (and likewise for "cluster settings" and "cluster variables"), I added some search synonyms.

Also added one that equates "MOLT" to "Migrate Off Legacy Technology" in search.

(Still need to test this in preview.)

@taroface taroface requested a review from florence-crl January 13, 2025 20:25
Copy link

Files changed:

  • src/current/jekyll-algolia-dev/lib/jekyll/algolia/indexer.rb

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit c8a1ac9
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67869c40eca9ca00087ad232

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit c8a1ac9
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67869c403847a8000814123f

Copy link

netlify bot commented Jan 13, 2025

Netlify Preview

Name Link
🔨 Latest commit c8a1ac9
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67869c4085a7d500089a9ab7
😎 Deploy Preview https://deploy-preview-19300--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my narrow testing, I do not see different results due to these entries. For example, run and compare the results of

  1. https://www.cockroachlabs.com/docs/search?query=cluster+variable
  2. https://www.cockroachlabs.com/docs/search?query=cluster+setting
  3. https://deploy-preview-19300--cockroachdb-docs.netlify.app/docs/search?query=cluster+variable
  4. https://deploy-preview-19300--cockroachdb-docs.netlify.app/docs/search?query=cluster+setting

The deploy preview results (3 & 4) match the current production results (1 & 2).
If the entries made a difference, I would expect 3 & 4 to have similar results.

Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw this slack thread:

Ryan Kuo
does anyone know if updating the search synonyms in indexer.rb is testable on the deploy preview?
Mike Lewis
I don’t believe so. I think the best we’ve been able to achieve is showing live Algolia results in preview builds, as opposed to Algolia results specific to what’s in the PR.

@taroface taroface enabled auto-merge (squash) January 14, 2025 17:17
@taroface taroface merged commit 9074f54 into main Jan 14, 2025
7 checks passed
@taroface taroface deleted the search-synonyms branch January 14, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants