-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add search synonyms for cluster settings, session settings, MOLT #19300
Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my narrow testing, I do not see different results due to these entries. For example, run and compare the results of
- https://www.cockroachlabs.com/docs/search?query=cluster+variable
- https://www.cockroachlabs.com/docs/search?query=cluster+setting
- https://deploy-preview-19300--cockroachdb-docs.netlify.app/docs/search?query=cluster+variable
- https://deploy-preview-19300--cockroachdb-docs.netlify.app/docs/search?query=cluster+setting
The deploy preview results (3 & 4) match the current production results (1 & 2).
If the entries made a difference, I would expect 3 & 4 to have similar results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw this slack thread:
Ryan Kuo
does anyone know if updating the search synonyms in indexer.rb is testable on the deploy preview?
Mike Lewis
I don’t believe so. I think the best we’ve been able to achieve is showing live Algolia results in preview builds, as opposed to Algolia results specific to what’s in the PR.
The search term "session settings" isn't turning up the Session Variables page. Since "session settings" and "session variables" are sometimes used interchangeably (and likewise for "cluster settings" and "cluster variables"), I added some search synonyms.
Also added one that equates "MOLT" to "Migrate Off Legacy Technology" in search.
(Still need to test this in preview.)