Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT and FLOAT aliases #1992

Merged
merged 3 commits into from
Oct 16, 2017
Merged

INT and FLOAT aliases #1992

merged 3 commits into from
Oct 16, 2017

Conversation

jseldess
Copy link
Contributor

Fixes #1634
Fixes #1661

@jseldess jseldess requested a review from m-schneider October 11, 2017 21:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/62dd9bcc3cb3aad3239da2a0260e60ecac909590/

@jseldess
Copy link
Contributor Author

@m-schneider, the issues we discussed are logged here: cockroachdb/cockroach#19197.

@jseldess
Copy link
Contributor Author

@m-schneider, any feedback on this?

@m-schneider
Copy link

:lgtm: I'll take a look at if we want to change some of this for 1.1.1

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

@jseldess
Copy link
Contributor Author

Thanks, @m-schneider.

@jseldess jseldess merged commit 4efbda0 into master Oct 16, 2017
@jseldess jseldess deleted the int-changes branch October 16, 2017 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-schneider m-schneider Awaiting requested review from m-schneider

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jseldess @cockroach-teamcity @m-schneider