Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cockroachdb: add crdbcluster options. #446

Open
wants to merge 1 commit into
base: poc-deploy-operator
Choose a base branch
from

Conversation

jmcarp
Copy link

@jmcarp jmcarp commented Jan 15, 2025

Add options to the crdbcluster template that we set in cloud, along with sensible defaults.

Add options to the crdbcluster template that we set in cloud, along with
sensible defaults.
@jmcarp jmcarp requested a review from pritesh-lahoti January 15, 2025 18:42
Copy link
Contributor

@pritesh-lahoti pritesh-lahoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving

Comment on lines +825 to +843
# Flags passed to the cockroachdb container.
flags:
# Disable backup/restore to local disk by default.
--external-io-dir: disabled

# Environment variables set on cockroachdb pods.
env: []

# Delay between cockroachdb pod restarts. Wait 3m by default to avoid
# unavailability during restarts.
rollingRestartDelay: 3m0s

# Topology spread constraints set on cockroachdb pods. Spread cockroachdb
# pods across zones by default.
topologySpreadConstraints:
- maxSkew: 1
topologyKey: topology.kubernetes.io/zone
whenUnsatisfiable: DoNotSchedule

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update build/templates/values.yaml and then run go run build/build.go generate to generate the changes to this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants