-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Picker with tests, tested in iOS/Android/OSX/Win already #11344
Conversation
…2d-x into v3-ImagePicker
Wow, this is great |
I'm quite sorry for so many commits. After digging into build farm console logs, I've added these files into WP8/W8/Linux |
@@ -0,0 +1,61 @@ | |||
#import <QuartzCore/QuartzCore.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ImagePicker-ios.mm
[ci rebuild] |
We are developing cocos package manager, which treat extension features as a plugin, so i think it is better to use cocos package manager to add image picker. Or cocos2d-x will more complex because all extensions will be integrated into cocos2d-x. @ricardoquesada |
@minggo I do agree to add as a plugin. I google around and only find some discussions. Is there any documentation or developer's guide? |
@dualface |
@minggo I would like to use this Image Picker with Cocos2d-JS ASAP as my project can't complete without this feature. I'm waiting this feature to be implemented since January. I believe there are a lot of Cocos2d developer who want to use this basic feature too and happy to see more basic features bring to Cocos2d. Is there any temporarily solution to make this Image Picker work with Cocos2d-JS v3.5? Thanks. |
I also need to have this feature for my upcoming project.. Can we integrate this first, and after cocos package manager ready, move this to package manager. Also, we don't know whether package manager will be available for developers outside china? |
Hi guys. |
I've added support for win8.1-universal. The code for phone version is a bit ugly since I cannot find a way to separate codes from However, when I try to compile wp8, the visual studio solution has some problems related to freetype2. Also, its This indeed shows that maintaining is a hard work 😄 |
…er creating texture; add texture->autorelease; speed up Android implementation
…er creating texture; add texture->autorelease; speed up Android implementation
…2d-x into v3-ImagePicker
The origin PR is here: #11296 by @Zinitter .
I'm the guy who wrote it and took some time tidying up my codes. Additionally, I put my codes in extensions and add the tests needed. For other platforms like linux/WP8, I only add an empty function which can compile but not work(Maybe I'll implement WP8 later, after google it...)