Magic Numbers used in Admin._stake() When Constant Defined Above Can Be Used Instead

[code423n4]

Handle

jvaqa

Vulnerability details

Impact

Magic Numbers are used in Admin._stake(), which both obscure the purpose of the function and unnecessarily lead to potential error if the constants are changed during development. Since they are used to refer to a constant defined in RoleAware, and Admin inherits from RoleAware, then Admin can simply call that constant.

Recommended Mitigation Steps

In Admin._stake(), change this:

IncentiveDistribution(incentiveDistributor()).addToClaimAmount(
1,
holder,
amount
);

to this:

IncentiveDistribution(incentiveDistributor()).addToClaimAmount(
FUND_TRANSFERER,
holder,
amount
);