Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can set values to more than 100% #102

Open
code423n4 opened this issue Jun 30, 2021 · 0 comments
Open

Can set values to more than 100% #102

code423n4 opened this issue Jun 30, 2021 · 0 comments
Labels
1 (Low Risk) bug Something isn't working sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

There are several setter functions that do not check if the amount is less than 100%.

  • TracerPerpetualSwaps: setFeeRate, setDeleveragingCliff, setInsurancePoolSwitchStage
  • Insurance: setFeeRate, setDeleveragingCliff, setInsurancePoolSwitchStage

Impact

Setting values to more than 100% might lead to unintended functionality.

Recommended Mitigation Steps

Ensure that the parameters are less than 100%.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) bug Something isn't working sponsor confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raymogg @code423n4