Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary type conversions #118

Open
code423n4 opened this issue Jun 30, 2021 · 0 comments
Open

Unnecessary type conversions #118

code423n4 opened this issue Jun 30, 2021 · 0 comments
Labels
0 (Non-critical) bug Something isn't working sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

tensors

Vulnerability details

Impact

Superfluous type conversions.

Proof of Concept

https://github.com/code-423n4/2021-06-tracer/blob/main/src/contracts/lib/LibBalances.sol#L229-L230
The type conversion here is not necessary.

Recommended Mitigation Steps

Remove the type conversion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) bug Something isn't working sponsor confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raymogg @code423n4