NestedFactory: _calculateFees has unused parameter _user

[code423n4]

Handle

PierrickGT

Vulnerability details

Impact

In _calculateFees, the parameter _user is passed to the function but never used inside of it.

Proof of Concept

Remove the _user parameter in _calculateFees to gain in code clarity. By removing this parameter, we also need to call the function without passing any address at the following lines:

• L228
• L298
• L354
• L548

Recommended Mitigation Steps

The following change is recommended.

function _calculateFees(uint256 _amount) private view returns (uint256) {
    return _amount / 100;
}

[maximebrugel]

Duplicated : #167