New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1. Cache length of array before loop to optimize gas #106

Closed

code423n4 opened this issue Nov 17, 2021 · 1 comment

Labels

bug duplicate G (Gas Optimization)

Contributor

code423n4 commented Nov 17, 2021

Handle

xYrYuYx

Vulnerability details

Impact

We can cache length of array before loop, to optimize gas.

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/OperatorResolver.sol#L45

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/OperatorResolver.sol#L56

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/FeeSplitter.sol#L108

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/FeeSplitter.sol#L125

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/FeeSplitter.sol#L227

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/MixinOperatorResolver.sol#L32

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/MixinOperatorResolver.sol#L48

Tools Used

Manual

Recommended Mitigation Steps

Cache length

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          xYrYuYx issue #106

63d4c2f

Collaborator

adrien-supizet commented Nov 19, 2021

duplicate #7

adrien-supizet added the duplicate label

adrien-supizet closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment