Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use calldata keyword instead of memory keyword in function arguments #107

Open
code423n4 opened this issue Nov 17, 2021 · 1 comment
Open

Use calldata keyword instead of memory keyword in function arguments #107

code423n4 opened this issue Nov 17, 2021 · 1 comment
Assignees
@maximebrugel
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

xYrYuYx

Vulnerability details

Impact

calldata use less gas than memory in function arguments

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/FeeSplitter.sol#L124

Tools Used

Manual

Recommended Mitigation Steps

Use calldata keyword in function argument instead of memory
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
xYrYuYx issue #107
70647f0
@maximebrugel
Copy link
Collaborator

Before => 286520 Gas
After => 286358 Gas

@maximebrugel maximebrugel added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 19, 2021
@maximebrugel maximebrugel mentioned this issue Nov 29, 2021
Merged
@maximebrugel maximebrugel self-assigned this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebrugel maximebrugel

Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maximebrugel @code423n4