Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zero-address checkers #108

Open
code423n4 opened this issue Nov 17, 2021 · 2 comments
Open

Add zero-address checkers #108

code423n4 opened this issue Nov 17, 2021 · 2 comments
Assignees
@maximebrugel
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

xYrYuYx

Vulnerability details

Impact

Add zero-address checkers, before use those argument

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/FeeSplitter.sol#L69

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/FeeSplitter.sol#L263

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedBuybacker.sol#L54-L56

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedBuybacker.sol#L68

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedBuybacker.sol#L75

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedFactory.sol#L44-L47

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedFactory.sol#L75

Tools Used

Manual

Recommended Mitigation Steps

Add zero-address checker
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
xYrYuYx issue #108
e6b46e3
@maximebrugel
Copy link
Collaborator

Duplicated : #83

@maximebrugel maximebrugel added the duplicate This issue or pull request already exists label Nov 19, 2021
@maximebrugel maximebrugel mentioned this issue Nov 19, 2021
Closed
@alcueca alcueca added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments and removed 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation labels Dec 3, 2021
@alcueca alcueca mentioned this issue Dec 3, 2021
Closed
@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

Taking as main, since it is the most complete

@alcueca alcueca reopened this Dec 3, 2021
This was referenced Dec 3, 2021
Closed
Closed
@CloudEllie CloudEllie removed the duplicate This issue or pull request already exists label Dec 3, 2021
@maximebrugel maximebrugel mentioned this issue Dec 21, 2021
Merged
@maximebrugel maximebrugel self-assigned this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebrugel maximebrugel

Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximebrugel @alcueca @code423n4 @CloudEllie