Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unchecked keyword #113

Closed
code423n4 opened this issue Nov 17, 2021 · 1 comment
Closed

Use unchecked keyword #113

code423n4 opened this issue Nov 17, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

xYrYuYx

Vulnerability details

Impact

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedBuybacker.sol#L110

since burnPercentage is less than 1000, toBurn is always less than balance.
So can use unchecked keyword to save gas.

Tools Used

Manaul

Recommended Mitigation Steps

Use unchecked keyword
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
xYrYuYx issue #113
3ea8e86
@adrien-supizet
Copy link
Collaborator

duplicate #173

@adrien-supizet adrien-supizet added the duplicate This issue or pull request already exists label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrien-supizet @code423n4