Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperatorResolver: importOperators() function redeclares local variable multiple times #119

Open
code423n4 opened this issue Nov 17, 2021 · 1 comment
Assignees
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

GreyArt

Vulnerability details

Impact

The importOperators() declares the name and destination variables multiple times. It'll be cheaper to declare them once outside the loop and reuse the variables inside.

Recommended Mitigation Steps

bytes32 name;
address destination;

for (uint256 i = 0; i < names.length; i++) {
	name = names[i];
	destination = destinations[i];
  operators[name] = destination;
  emit OperatorImported(name, destination);
}
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@maximebrugel maximebrugel added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Nov 19, 2021
@maximebrugel
Copy link
Collaborator

maximebrugel commented Nov 19, 2021

image
image

@maximebrugel maximebrugel added sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") and removed sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue labels Nov 19, 2021
@maximebrugel maximebrugel self-assigned this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

2 participants