Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestedRecords: Unnecessary variable in the Holding struct #121

Open
code423n4 opened this issue Nov 17, 2021 · 0 comments
Open

NestedRecords: Unnecessary variable in the Holding struct #121

code423n4 opened this issue Nov 17, 2021 · 0 comments
Assignees
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

GreyArt

Vulnerability details

Impact

It is unnecessary to store the token variable in the Holding struct because the token is used as the key to access the Holding struct.

Recommended Mitigation Steps

Remove the token variable in the Holding struct.

/// @dev Info about assets stored in reserves
struct Holding {
  uint256 amount;
  bool isActive;
}
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@maximebrugel maximebrugel added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 19, 2021
@maximebrugel maximebrugel self-assigned this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

2 participants