Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MixinOperatorResolver: variables are declared multiple times in rebuildCache() #122

Open
code423n4 opened this issue Nov 17, 2021 · 0 comments
Assignees
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

GreyArt

Vulnerability details

Impact

The name and destination local variables in the rebuildCache function are declared multiple times within the loop. It'll be cheaper to declare them once outside the loop and reuse the variables inside.

Recommended Mitigation Steps

bytes32 name;
address destination;
// The resolver must call this function whenever it updates its state
for (uint256 i = 0; i < requiredAddresses.length; i++) {
	name = requiredAddresses[i];
	// Note: can only be invoked once the resolver has all the targets needed added
	destination = resolver.getAddress(name);
  ...
}
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@maximebrugel maximebrugel added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 19, 2021
@maximebrugel maximebrugel self-assigned this Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

2 participants