NestedRecords: createRecord() can be made internal

[code423n4]

Handle

GreyArt

Vulnerability details

Impact

createRecord() is only invoked by store(). Its visibility can therefore be made internal / private.

Recommended Mitigation Steps

function createRecord(
  uint256 _nftId,
  address _token,
  uint256 _amount,
	address _reserve
) internal onlyFactory {...}

[maximebrugel]

Will make createRecord internal (or move inside store) and remove redundant checks