NestedFactory: _fromReserve param in _submitOutOrders() is redundant

[code423n4]

Handle

GreyArt

Vulnerability details

Impact

_submitOutOrders() is invoked by 2 functions sellTokensToNft() and sellTokensToWallet(), both of which specify the _fromReserve parameter to be true. This parameter is therefore unneeded.

Recommended Mitigation Steps

function _submitOutOrders(
  uint256 _nftId,
  IERC20 _outputToken,
  uint256[] memory _inputTokenAmounts,
  Order[] calldata _orders,
  bool _reserved
) private returns (uint256 feesAmount, uint256 amountBought) {
	...
	
	IERC20 _inputToken = _transferInputTokens(
    _nftId,
    IERC20(_orders[i].token),
    _inputTokenAmounts[i],
    true
	);
}

[maximebrugel]

The parameter was added in the case of _submitOutOrders from a wallet (not the portfolio/reserve) to set the value to false. Since we are not allowing to do this, we can remove it.

However, it is not a bad idea to include a deposit function to add multiple tokens.

[maximebrugel]

Same in _submitInOrders with _reserved