Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused local variables #153

Closed
code423n4 opened this issue Nov 17, 2021 · 3 comments
Closed

Unused local variables #153

code423n4 opened this issue Nov 17, 2021 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

WatchPug

Vulnerability details

Unused local variables in contracts increase contract size and gas usage at deployment.

Instances include:

https://github.com/code-423n4/2021-11-nested/blob/f646002b692ca5fa3631acfff87dda897541cf41/contracts/NestedFactory.sol#L379-L383

(uint256[] memory amounts, address[] memory tokens) = OperatorHelpers.decodeDataAndRequire(
    data,
    _inputToken,
    _outputToken
);

tokens is unused.

https://github.com/code-423n4/2021-11-nested/blob/f646002b692ca5fa3631acfff87dda897541cf41/contracts/NestedFactory.sol#L410-L414

(uint256[] memory amounts, address[] memory tokens) = OperatorHelpers.decodeDataAndRequire(
    data,
    _inputToken,
    _outputToken
);

tokens is unused.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
WatchPug issue #153
36fe410
@adrien-supizet adrien-supizet added the duplicate This issue or pull request already exists label Nov 18, 2021
@adrien-supizet
Copy link
Collaborator

duplicate #195

@maximebrugel
Copy link
Collaborator

also duplicate #67 & #66

@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

#195 as the main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximebrugel @adrien-supizet @alcueca @code423n4