Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot change tokenUri #179

Open
code423n4 opened this issue Nov 17, 2021 · 2 comments
Open

Cannot change tokenUri #179

code423n4 opened this issue Nov 17, 2021 · 2 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The NestedAsset.backfillTokenURI function can only be called by the factory but the factory never calls it.

Impact

Unused code can hint at programming or architectural errors.
When minting tokens (using mint) it sets no tokenURI and there's currently no way to set it anymore.

Recommended Mitigation Steps

Add a way to use backfillTokenURI.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
cmichel issue #179
44868b6
@adrien-supizet adrien-supizet added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Nov 19, 2021
@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

Disputed on which grounds, @adrien-supizet?

@adrien-supizet
Copy link
Collaborator

adrien-supizet commented Dec 3, 2021 •
edited
Loading

@alcueca Sorry for the missing details. Here it is:

The NestedAsset contract is not upgradeable, the NFT collection is here to stay.
Even though today we do not need to store any metadata in the NFTs, we know it's very likely to be the case in the future.

Indeed, the current NestedFactory does not use this function, but we assume that the next factory might. Therefore we want to keep this unused function.

@maximebrugel maximebrugel mentioned this issue Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adrien-supizet @alcueca @code423n4