Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas: Unnecessary balanceOf call #184

Closed
code423n4 opened this issue Nov 17, 2021 · 1 comment
Closed

Gas: Unnecessary balanceOf call #184

code423n4 opened this issue Nov 17, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The NestedBuybacker.triggerForToken gets the _sellToken balance but does never use this result.

// this balance is never used
uint256 balance = _sellToken.balanceOf(address(this));

A good compiler should eliminate dead code but it's better to remove unused code in the first place.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
cmichel issue #184
bcb6735
@maximebrugel maximebrugel added the duplicate This issue or pull request already exists label Nov 17, 2021
@maximebrugel
Copy link
Collaborator

Duplicated : #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maximebrugel @code423n4