Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Solidity pragma in contracts/mocks/DummyRouter.sol #23

Closed
code423n4 opened this issue Nov 13, 2021 · 2 comments
Closed

Multiple Solidity pragma in contracts/mocks/DummyRouter.sol #23

code423n4 opened this issue Nov 13, 2021 · 2 comments
Labels
bug Something isn't working invalid This doesn't seem right sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Handle

fatima_naz

Vulnerability details

Impact

In contracts/mocks/DummyRouter.sol
pragma solidity ^0.8.3;
It is better to use one Solidity compiler version across all contracts instead of different versions with different bugs and security checks. All the other files use 0.8.9 .

Proof of Concept

https://github.com/crytic/slither/wiki/Detector-Documentation#different-pragma-directives-are-used

Tools Used

Recommended Mitigation Steps

change the line with
pragma solidity 0.8.9;

@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 13, 2021
code423n4 added a commit that referenced this issue Nov 13, 2021
@adrien-supizet adrien-supizet added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Nov 18, 2021
@adrien-supizet
Copy link
Collaborator

This is one issue described in multiple PRs #19 #20 #21 #22 #23 #24
We don't believe this is an issue at all as the contracts deployed on the blockchain sometimes have older pragma, we believe it's normal to use mock contracts with the same pragma when we copy it from ehterscan.

@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

One issue about unlocked pragmas is enough.

@alcueca alcueca closed this as completed Dec 3, 2021
@alcueca alcueca added invalid This doesn't seem right and removed 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Development

No branches or pull requests

3 participants