Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestedReserve.transferFromFactory function increases deployment gas costs unnecessarily #27

Open
code423n4 opened this issue Nov 13, 2021 · 0 comments
Open

NestedReserve.transferFromFactory function increases deployment gas costs unnecessarily #27

code423n4 opened this issue Nov 13, 2021 · 0 comments
Assignees
@maximebrugel
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

TomFrench

Vulnerability details

Impact

NestedReserve.transferFromFactory is unused and so increases deployment costs for no gain

Proof of Concept

NestedReserve has a transferFromFactory which can be seen not to be used in the codebase (and in the case the NestedFactory needs to send tokens to the reserve it can do so directly.)

https://github.com/code-423n4/2021-11-nested/blob/5d113967cdf7c9ee29802e1ecb176c656386fe9b/contracts/NestedReserve.sol#L55-L60

Recommended Mitigation Steps

Remove this function.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 13, 2021
code423n4 added a commit that referenced this issue Nov 13, 2021
@code423n4
TomFrench issue #27
b7c1bf6
@maximebrugel maximebrugel added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 18, 2021
@maximebrugel maximebrugel mentioned this issue Nov 25, 2021
Merged
@maximebrugel maximebrugel self-assigned this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebrugel maximebrugel

Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maximebrugel @code423n4