Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing events for critical privileged functions #42

Open
code423n4 opened this issue Nov 14, 2021 · 2 comments
Open

Missing events for critical privileged functions #42

code423n4 opened this issue Nov 14, 2021 · 2 comments
Assignees
@maximebrugel
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

GiveMeTestEther

Vulnerability details

Impact

Functions that are only executable by privileged users (e.g. onlyOwner) and have an impact (e.g. financial, trust) on other users should emit events.

Proof of Concept

https://github.com/code-423n4/2021-11-nested/blob/5d113967cdf7c9ee29802e1ecb176c656386fe9b/contracts/FeeSplitter.sol#L94
https://github.com/code-423n4/2021-11-nested/blob/5d113967cdf7c9ee29802e1ecb176c656386fe9b/contracts/FeeSplitter.sol#L103
https://github.com/code-423n4/2021-11-nested/blob/5d113967cdf7c9ee29802e1ecb176c656386fe9b/contracts/FeeSplitter.sol#L166

https://github.com/code-423n4/2021-11-nested/blob/5d113967cdf7c9ee29802e1ecb176c656386fe9b/contracts/NestedFactory.sol#L74
https://github.com/code-423n4/2021-11-nested/blob/5d113967cdf7c9ee29802e1ecb176c656386fe9b/contracts/NestedFactory.sol#L79
https://github.com/code-423n4/2021-11-nested/blob/5d113967cdf7c9ee29802e1ecb176c656386fe9b/contracts/NestedFactory.sol#L271

and possible other

Tools Used

Manual Analysis

Recommended Mitigation Steps

Emit events for privileged actions
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 14, 2021
code423n4 added a commit that referenced this issue Nov 14, 2021
@code423n4
GiveMeTestEther issue #42
455a2fe
@maximebrugel maximebrugel self-assigned this Nov 18, 2021
@adrien-supizet
Copy link
Collaborator

Functions mentioned:

setRoyaltiesWeight
setShareholders
updateShareholder
addOperator
removeOperator
unlockTokens

@maximebrugel maximebrugel mentioned this issue Nov 19, 2021
Closed
@maximebrugel maximebrugel added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Nov 19, 2021
This was referenced Nov 19, 2021
Closed
Closed
Closed
@maximebrugel maximebrugel added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 23, 2021
@maximebrugel maximebrugel removed their assignment Nov 25, 2021
@alcueca alcueca added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Dec 3, 2021
@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

Issues with events are non-critical

@maximebrugel maximebrugel mentioned this issue Dec 21, 2021
Merged
@maximebrugel maximebrugel self-assigned this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebrugel maximebrugel

Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximebrugel @adrien-supizet @alcueca @code423n4