Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestedFactory: _submitOrder one mload can be avoided #6

Closed
code423n4 opened this issue Nov 11, 2021 · 2 comments
Closed

NestedFactory: _submitOrder one mload can be avoided #6

code423n4 opened this issue Nov 11, 2021 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

PierrickGT

Vulnerability details

Impact

In _submitOrder, we load in memory the return parameter tokens from decodeDataAndRequire but this variable isn't used afterward.

Proof of Concept

Avoid loading tokens from decodeDataAndRequire to save on gas and gain in code clarity.
https://github.com/code-423n4/2021-11-nested/blob/cbd39fe7d76ed8c84eb767a5f3b6eba83e034656/contracts/NestedFactory.sol#L379

Recommended Mitigation Steps

The following change is recommended.

(uint256[] memory amounts,) = OperatorHelpers.decodeDataAndRequire(
    data,
    _inputToken,
    _outputToken
);
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 11, 2021
code423n4 added a commit that referenced this issue Nov 11, 2021
@code423n4
PierrickGT issue #6
028ed12
@maximebrugel maximebrugel added the duplicate This issue or pull request already exists label Nov 16, 2021
@maximebrugel
Copy link
Collaborator

Duplicated : #66

@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

#195 as the main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximebrugel @alcueca @code423n4