Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The _user parameter of _calculateFees is not used #62

Closed
code423n4 opened this issue Nov 15, 2021 · 2 comments
Closed

The _user parameter of _calculateFees is not used #62

code423n4 opened this issue Nov 15, 2021 · 2 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

loop

Vulnerability details

_calculateFees only makes use of _amount to calculate fees, the _user parameter can be removed.

Impact

Since _calculateFees is only called internally it does add to gas costs, an unused parameter adds a small amount of unnecessary gas.

Proof of Concept

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedFactory.sol#L557-L559

Tools Used

Remix
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 15, 2021
code423n4 added a commit that referenced this issue Nov 15, 2021
@code423n4
loop issue #62
5be012f
@maximebrugel maximebrugel added the duplicate This issue or pull request already exists label Nov 17, 2021
@maximebrugel
Copy link
Collaborator

Duplicated : #167

@alcueca alcueca added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments and removed G (Gas Optimization) labels Dec 3, 2021
@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

Also comments are wrong (#194)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximebrugel @alcueca @code423n4