Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeFactory has ==true comparison in require statement #63

Open
code423n4 opened this issue Nov 15, 2021 · 0 comments
Open

removeFactory has ==true comparison in require statement #63

code423n4 opened this issue Nov 15, 2021 · 0 comments
Assignees
@maximebrugel
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

loop

Vulnerability details

The removeFactory has an unnecessary ==true comparison in its require statement. Since require already checks if the condition is true, there is no need for it to be compared.

Impact

Removing == true saves a tiny amount of gas if removeFactory is called.

Proof of Concept

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedAsset.sol#L142
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 15, 2021
code423n4 added a commit that referenced this issue Nov 15, 2021
@code423n4
loop issue #63
1e0e07e
@adrien-supizet adrien-supizet added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 17, 2021
@adrien-supizet adrien-supizet mentioned this issue Nov 17, 2021
Closed
@maximebrugel maximebrugel mentioned this issue Nov 29, 2021
Merged
@maximebrugel maximebrugel self-assigned this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebrugel maximebrugel

Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximebrugel @adrien-supizet @code423n4