Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverlayV1Mothership doesn't emit events #19

Closed
code423n4 opened this issue Nov 19, 2021 · 1 comment
Closed

OverlayV1Mothership doesn't emit events #19

code423n4 opened this issue Nov 19, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

0x0x0x

Vulnerability details

Impact

Since OverlayV1Mothership doesn't emit events, goverrnance can change parameters without notice. All functions with onlyGovernor inside Mothership should emit events. Otherwise, this would not create a safe environment for users. Furthermore, in case of governance is stolen, this can be abused to steal funds from users without notice by changing fee and feeTo.

Tools Used

Manual analysis
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Nov 19, 2021
code423n4 added a commit that referenced this issue Nov 19, 2021
@code423n4
0x0x0x issue #19
72b6517
@mikeyrf mikeyrf added the duplicate This issue or pull request already exists label Dec 7, 2021
@mikeyrf
Copy link
Collaborator

mikeyrf commented Dec 7, 2021

duplicate #64

@mikeyrf mikeyrf closed this as completed Dec 7, 2021
@dmvt dmvt added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmvt @mikeyrf @code423n4