Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit event when fees are changed in Mothership contract #31

Closed
code423n4 opened this issue Nov 19, 2021 · 1 comment
Closed

Emit event when fees are changed in Mothership contract #31

code423n4 opened this issue Nov 19, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

Ruhum

Vulnerability details

Impact

Changing the fees should be accompanied by an event so external parties are notified.

Proof of Concept

https://github.com/code-423n4/2021-11-overlay/blob/main/contracts/mothership/OverlayV1Mothership.sol#L163

Tools Used

Manual Analysis

Recommended Mitigation Steps

create a new event and emit it
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 19, 2021
code423n4 added a commit that referenced this issue Nov 19, 2021
@code423n4
Ruhum issue #31
49c9c6b
@mikeyrf mikeyrf added the duplicate This issue or pull request already exists label Dec 7, 2021
@mikeyrf
Copy link
Collaborator

mikeyrf commented Dec 7, 2021

duplicate #64

@mikeyrf mikeyrf closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeyrf @code423n4