Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No upper limit check on swap fee Percentage #182

Open
code423n4 opened this issue Feb 2, 2022 · 2 comments
Open

No upper limit check on swap fee Percentage #182

code423n4 opened this issue Feb 2, 2022 · 2 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments)

Comments

@code423n4
Copy link
Contributor

Handle

samruna

Vulnerability details

https://github.com/code-423n4/2022-01-notional/blob/main/contracts/sNOTE.sol#L133

No upper limit check on swapFeePercentage. Although only owner can set this, human error can lead to higher percente swap, leading to excess swap and gas fee.
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working labels Feb 2, 2022
code423n4 added a commit that referenced this issue Feb 2, 2022
@code423n4
samruna issue #182
147439c
@jeffywu jeffywu added the disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) label Feb 6, 2022
@jeffywu
Copy link
Collaborator

jeffywu commented Feb 6, 2022

Severity should be Low Risk

@jeffywu jeffywu mentioned this issue Feb 6, 2022
Closed
@pauliax
Copy link
Collaborator

pauliax commented Feb 14, 2022

Having a reasonable upper boundary would be a good improvement here, but I agree with the sponsor that this should be of low severity.

@pauliax pauliax added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments and removed 3 (High Risk) Assets can be stolen/lost/compromised directly labels Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffywu @pauliax @code423n4