Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getVotingPower division by zero #191

Closed
code423n4 opened this issue Feb 2, 2022 · 2 comments
Closed

getVotingPower division by zero #191

code423n4 opened this issue Feb 2, 2022 · 2 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The sNOTE.getVotingPower function divides by zero and reverts if no sNOTE tokens have been minted yet (totalSupply() == 0).

return (noteAmount * sNOTEAmount) / totalSupply();

Recommended Mitigation Steps

Return a voting power of 0 if totalSupply() == 0.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Feb 2, 2022
code423n4 added a commit that referenced this issue Feb 2, 2022
@code423n4
cmichel issue #191
8ff9328
@jeffywu jeffywu added the duplicate This issue or pull request already exists label Feb 6, 2022
@jeffywu
Copy link
Collaborator

jeffywu commented Feb 6, 2022

Duplicate of #170

@jeffywu jeffywu marked this as a duplicate of #170 Feb 6, 2022
@pauliax
Copy link
Collaborator

pauliax commented Feb 14, 2022

#170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jeffywu @pauliax @code423n4 @CloudEllie