Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StorageId enums may never be shuffled #196

Open
code423n4 opened this issue Feb 2, 2022 · 2 comments
Open

StorageId enums may never be shuffled #196

code423n4 opened this issue Feb 2, 2022 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The StorageId is not only append-only as the comment says, its values may also never be shuffled.

Impact

Wrong slots are read and written in an update that shuffles the values.

Recommended Mitigation Steps

Never shuffle the values.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Feb 2, 2022
code423n4 added a commit that referenced this issue Feb 2, 2022
@code423n4
cmichel issue #196
f7fd107
@jeffywu jeffywu added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Feb 6, 2022
@jeffywu
Copy link
Collaborator

jeffywu commented Feb 6, 2022

The comment already specifies that they cannot be shuffled. There is no programmatic way to enforce this that I know of.

@pauliax
Copy link
Collaborator

pauliax commented Feb 14, 2022

I am leaving this as a non-critical reminder.

@pauliax pauliax added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffywu @pauliax @code423n4