Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused state variables #204

Open
code423n4 opened this issue Feb 2, 2022 · 1 comment
Open

Unused state variables #204

code423n4 opened this issue Feb 2, 2022 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

Unused state variables:

    uint256 public constant BPT_TOKEN_PRECISION = 1e18;
    uint256 internal constant ETH_PRECISION = 1e18;
    uint32 public refundGasPrice;

Either remove them or use them where intended.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Feb 2, 2022
code423n4 added a commit that referenced this issue Feb 2, 2022
@code423n4
pauliax issue #204
f53fc56
@jeffywu jeffywu added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Feb 6, 2022
@pauliax
Copy link
Collaborator

pauliax commented Feb 15, 2022

This issue mentions all the 3 state variables that can be safely removed, so I am making this a primary issue and grouping all the issues related to unused variables together.

This was referenced Feb 15, 2022
Closed
Closed
Closed
Closed
Closed
weitianjie2000 added a commit to notional-finance/staked-note that referenced this issue Feb 15, 2022
@weitianjie2000
Unused state variables [code-423n4/2022-01-notional-findings#204]
ce76e30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffywu @pauliax @code423n4