Repeated calculations of the same values

[code423n4]

Handle

pauliax

Vulnerability details

Impact

In function _redeemAndTransfer this is repeated twice:

  if (underlying.tokenAddress == address(0)) {
      ...
  }
  address underlyingAddress = underlying.tokenAddress == address(0)
  ...

You should cache and re-use it to avoid repeated calculations.

[pauliax]

#213