considered changing it to storage

[code423n4]

Handle

Tomio

Vulnerability details

Impact

Expensive gas

Proof of Concept

https://github.com/code-423n4/2022-01-notional/blob/main/contracts/sNOTE.sol#L305
// gas cost 24474

Tools Used

Remix

Recommended Mitigation Steps

Change to:

AccountCoolDown storage coolDown = accountCoolDown[account];
// gas cost 24185

[jeffywu]

Report is unclear, proposed behavior is not what matches the existing code.

[pauliax]

I think the warden suggested to change from this:

        AccountCoolDown memory coolDown = accountCoolDown[account];

to this:

        AccountCoolDown storage coolDown = accountCoolDown[account];

and from my understanding. this might slightly reduce gas costs because accountCoolDown is a storage variable.