Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #228

Open
code423n4 opened this issue Feb 9, 2022 · 1 comment
Open

Gas Optimizations #228

code423n4 opened this issue Feb 9, 2022 · 1 comment
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Remove SafeMath from most gas consuming functions

Now you are using solidity 0.8 you can remove SafeMath .

https://github.com/code-423n4/2022-02-concur/blob/72b5216bfeaa7c52983060ebfc56e72e0aa8e3b0/contracts/MasterChef.sol#L119-L121

The following is important I believe as you mention massUpdatePools() consumes lot of gas

https://github.com/code-423n4/2022-02-concur/blob/72b5216bfeaa7c52983060ebfc56e72e0aa8e3b0/contracts/MasterChef.sol#L151-L152
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Feb 9, 2022
code423n4 added a commit that referenced this issue Feb 9, 2022
@code423n4
peritoflores issue #228
08e230d
@GalloDaSballo
Copy link
Collaborator

6 * 20 = 120 gas saved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GalloDaSballo @code423n4