QA Report #109
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
sponsor acknowledged
Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Several improvements needed in Vanilla Governable contract
Consider adding Two-step transfer ownership pattern in setGovernance function
This function is dangerous because do not even check if
_governance!=address(0)
so probability to make a mistake is higher. Maybe this issue can even be considered medium for that reason.You can add that check or implement two-step transfer ownership with functions
setPendingGovernance
andacceptGovernance
Consider adding emit event when setting new governance
The text was updated successfully, but these errors were encountered: