Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #109

Open
code423n4 opened this issue Feb 23, 2022 · 0 comments
Open

QA Report #109

code423n4 opened this issue Feb 23, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Several improvements needed in Vanilla Governable contract

Consider adding Two-step transfer ownership pattern in setGovernance function

function setGovernace(address _governance) external onlyGovernance {
    _setGovernace(_governance);
}

This function is dangerous because do not even check if _governance!=address(0) so probability to make a mistake is higher. Maybe this issue can even be considered medium for that reason.
You can add that check or implement two-step transfer ownership with functions setPendingGovernance and acceptGovernance

Consider adding emit event when setting new governance

event newPendingGovernance(address pendingGovernance);
event newGovernance(address governance);
@code423n4 code423n4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax bug Something isn't working labels Feb 23, 2022
code423n4 added a commit that referenced this issue Feb 23, 2022
@atvanguard atvanguard added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

2 participants