Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #134

Open
code423n4 opened this issue Feb 23, 2022 · 1 comment
Open

QA Report #134

code423n4 opened this issue Feb 23, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

  • Return address utilises private state variable in inheritance :

[https://github.com/code-423n4/2022-02-hubble/blob/main/contracts/legos/HubbleBase.sol#L23]

This function will not be invoked. This is due to the fact that the address to be returned is marked ‘private’ in the inherited Erc777Context contract. It is advised to remove this function, or follow the OZ implementation and override isTrustedForwarder().
@code423n4 code423n4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax bug Something isn't working labels Feb 23, 2022
code423n4 added a commit that referenced this issue Feb 23, 2022
@code423n4
0xwags issue #134
4a2b6ca
@atvanguard atvanguard added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Feb 26, 2022
@atvanguard
Copy link
Collaborator

In the OZ version being used, _trustedForwarder is an internal variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atvanguard @code423n4