Gas Optimizations

[code423n4]

Unused transfer function in NestedReserve

The transfer function in NestedReserve can be only called by NestedFactory, yet the factory doesn't use it. There are specific unit tests for this function but it is not used in the protocol.
Removing it will save 61414 gas on deployment costs.
Note: it is possible you are leaving it there for the future in case NestedFactory will be upgraded and you want this functionality to be possible. If so, this issue is invalid. But maybe it's just an old leftover.

Unused ETH variable in FeeSplitter

FeeSplitter contains an unused ETH variable:

    address private constant ETH = 0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE;

You can remove it for cleanliness and to save 500 gas at deployment.

Change NestedFactory's ETH variable to be immutable

By changing this variable in NestedFactory to immutable instead of constant:

    address private constant ETH = 0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE;

You will save 30-70 gas on various calls.

[adrien-supizet]

Unused transfer function in NestedReserve

We want to keep it for use cases such as migration or staking of deposited tokens.

Unused ETH variable in FeeSplitter

duplicate #25

Change NestedFactory's ETH variable to be immutable

Duplicated #15

[harleythedogC4]

My personal judgments:

1. "Unused transfer function in NestedReserve". Valid and medium-optimization.
2. "Unused ETH variable in FeeSplitter". Valid and small-optimization.
3. "Change NestedFactory's ETH variable to be immutable". Valid and small-optimization.

[harleythedogC4]

Now, here is the methodology I used for calculating a score for each gas report. I first assigned each submission to be either small-optimization (1 point), medium-optimization (5 points) or large-optimization (10 points), depending on how useful the optimization is. The score of a gas report is the sum of these points, divided by the maximum number of points achieved by a gas report. This maximum number was 10 points, achieved by #67.

The number of points achieved by this report is 7 points.
Thus the final score of this gas report is (7/10)*100 = 70.