QA Report

[code423n4]

Non-critical

Multiple unnecessary indents

Consider changing lines 798-800 of HolyPaladinToken.sol to the following code:

if(userLastIndex == currentRewardsIndex || balanceOf(user) == 0) {
	return;
}

By doing so multiple unnecessary indents can be avoided making the code easier to read.

Avoid duplicating code

Consider creating a function that sets voting power to avoid duplicating code in _moveDelegates function.

Spelling mistake in the name of the variable ellapsedTime

There is a spelling mistake in the name of the variable ellapsedTime in _getNewIndex function (lines 748 and 755). It should be called elapsedTime instead.

Function _getPastDelegate is unused

Function _getPastDelegate (present in lines 993-1023 of HolyPaladinToken.sol) in exactly the same as function getPastDelegate (present in lines 663-702 of the same file) and it is currently unused. Thus, this function should be removed.

Low

Incorrect value of kickRatioPerWeek

According to the documentation, the penalty of the locked balance after a lock is expired is 1%, but in HolyPaladinToken.sol:97 it is defined to be 10%.

[Kogaroshi]

QA & gas optimizations changes are done in the PR: PaladinFinance/Paladin-Tokenomics#6
(some changes/tips were implemented, others are noted but won't be applied)