Re-entrancy Guard Is Not Initialized

[code423n4]

Lines of code

https://github.com/code-423n4/2022-03-prepo/blob/main/contracts/core/PrePOMarketFactory.sol#L15

Vulnerability details

Impact

During the manual code review, It has been observed that re-entrancy guard (ReentrancyGuardUpgradeable) contract is not initialized. The contract should be initialized in the initialize function.

Proof of Concept

1. Navigate to the following contract.

https://github.com/code-423n4/2022-03-prepo/blob/main/contracts/core/PrePOMarketFactory.sol#L15

Tools Used

Code Review

Recommended Mitigation Steps

Consider initializing function in the related section.

    function initialize() public initializer {
        OwnableUpgradeable.__Ownable_init();
        __ReentrancyGuard_init();
    }

[ramenforbreakfast]

Valid claim, however I dispute the severity to low-risk since nonReentrant should still work as intended even if its entrance variable is not initialized.

[ramenforbreakfast]

I consider #106 to be a higher quality submission regarding this issue.

[gzeoneth]

Agree with sponsor, downgrading to Low/QA. Closing in favor of warden's QA report #113