Unsafe Cast

[code423n4]

Lines of code

https://github.com/sublime-finance/sublime-v1/blob/46536a6d25df4264c1b217bd3232af30355dcb95/contracts/PooledCreditLine/PooledCreditLine.sol

Vulnerability details

use openzeppilin's safeCast in:

    PooledCreditLine.accept : unsafe cast uint128(_amount)

[ritik99]

uint128 can hold up to 2^128 ~ 3.4*10^38 which is higher than any token's max supply. We also implement a whitelist for which tokens can be borrowed and include appropriate conditions (for eg, only considering tokens with max. 18 decimals). We consider this cast as safe, but out of an abundance of caution, we will implement the suggestion.

Given there are no other information/scenario details provided, we're assuming this will only cause an issue if the two conditions are met (token supply exceeding 3.4*10^38, and such a token-passing whitelist checks). Thus we would suggest lowering severity to (1) low given their likelihood.

[HardlyDifficult]

Grouping this with the warden’s QA report, #3