Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #213

Open
code423n4 opened this issue Apr 20, 2022 · 0 comments
Open

QA Report #213

code423n4 opened this issue Apr 20, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

LOW AND NC for Badger Citadel by PeritoFlores

[L-01] Missing zero-address check in claim function

External function claim#StackedCitadelVester.solis missing zero-address check for the parameter recipient . User could accidentally burn vestingTokens by transfering them to zero-address.

Recommended

Add

require(recipient =! address(0))

[L-02] Lack of event emission at clearCitadelPriceFlag

Function clearCitadelPriceFlag#Funding.sol is missing an event after setting the parameter

citadelpriceFlag to false.

This is important as users will be unaware and can call the public function deposit#Funding.sol that will revert and will spend gas unnecessarily.

Recommended

Add event

[NC-01] Lack of event emission in several functions at SettAccessControl contract

Functions setStrategist, setKeeper and setGovernance lack even emission after those variables are set. Consider adding new events and emit them at the end of every function.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Apr 20, 2022
code423n4 added a commit that referenced this issue Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

1 participant