QA Report #213
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
LOW AND NC for Badger Citadel by PeritoFlores
[L-01] Missing zero-address check in
claim
functionExternal function
claim#StackedCitadelVester.sol
is missing zero-address check for the parameterrecipient
. User could accidentally burn vestingTokens by transfering them to zero-address.Recommended
Add
require(recipient =! address(0))
[L-02] Lack of event emission at clearCitadelPriceFlag
Function
clearCitadelPriceFlag#Funding.sol
is missing an event after setting the parametercitadelpriceFlag
to false.This is important as users will be unaware and can call the public function
deposit#Funding.sol
that will revert and will spend gas unnecessarily.Recommended
Add event
[NC-01] Lack of event emission in several functions at SettAccessControl contract
Functions
setStrategist
,setKeeper
andsetGovernance
lack even emission after those variables are set. Consider adding new events and emit them at the end of every function.The text was updated successfully, but these errors were encountered: