Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safeTransfer is recommended instead of transfer (2) #44

Closed
code423n4 opened this issue Apr 29, 2022 · 2 comments
Closed

safeTransfer is recommended instead of transfer (2) #44

code423n4 opened this issue Apr 29, 2022 · 2 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists invalid This doesn't seem right

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-04-mimo/blob/b18670f44d595483df2c0f76d1c57a7bfbfbc083/supervaults/contracts/SuperVault.sol#L237

Vulnerability details

Impact

ERC20 standard allows transfer function of some contracts to return bool or return nothing. Using safeTransfer of SafeERC20.sol is recommended instead.

Proof of Concept

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/4a9cc8b4918ef3736229a5cc5a310bdc17bf759f/contracts/token/ERC20/utils/SafeERC20.sol

Tools Used

Recommended Mitigation Steps

Recommended code:
collateral.safeTransfer(msg.sender, collateral.balanceOf(address(this)));
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Apr 29, 2022
code423n4 added a commit that referenced this issue Apr 29, 2022
@code423n4
MaratCerby issue #44
1fdb8f7
@m19 m19 mentioned this issue May 5, 2022
Closed
@m19 m19 added the duplicate This issue or pull request already exists label May 10, 2022
@m19
Copy link
Collaborator

m19 commented May 10, 2022

Duplicate of #124

@m19 m19 marked this as a duplicate of #124 May 10, 2022
@m19 m19 closed this as completed May 10, 2022
@gzeoneth
Copy link
Member

gzeoneth commented Jun 5, 2022

Duplicate of #43 by the same warden.

@gzeoneth gzeoneth added the invalid This doesn't seem right label Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m19 @code423n4 @gzeoneth