Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #7

Closed
code423n4 opened this issue Apr 28, 2022 · 1 comment
Closed

QA Report #7

code423n4 opened this issue Apr 28, 2022 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Critical functions should emit events

These critical function should emit an event, please also considereing adding a timelock in these functions.

File:
https://github.com/code-423n4/2022-04-mimo/blob/f088e83f79b5ec66fb5eb39e6bb9fe33f446dd49/core/contracts/core/AddressProvider.sol#L38-L81

File:
https://github.com/code-423n4/2022-04-mimo/blob/f088e83f79b5ec66fb5eb39e6bb9fe33f446dd49/core/contracts/liquidityMining/v2/PARMinerV2.sol#L82-L84

These critical function should emit an event.

https://github.com/code-423n4/2022-04-mimo/blob/f088e83f79b5ec66fb5eb39e6bb9fe33f446dd49/core/contracts/dex/DexAddressProvider.sol#L33-L34
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Apr 28, 2022
code423n4 added a commit that referenced this issue Apr 28, 2022
@code423n4
0x4non issue #7
fcc4665
@code423n4 code423n4 mentioned this issue May 2, 2022
Open
@gzeoneth
Copy link
Member

gzeoneth commented Jun 5, 2022

Duplicate of #3

@gzeoneth gzeoneth marked this as a duplicate of #3 Jun 5, 2022
@gzeoneth gzeoneth closed this as completed Jun 5, 2022
@gzeoneth gzeoneth added the duplicate This issue or pull request already exists label Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @gzeoneth