Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #1

Closed
code423n4 opened this issue Apr 29, 2022 · 2 comments
Closed

Gas Optimizations #1

code423n4 opened this issue Apr 29, 2022 · 2 comments
Assignees
@PierrickGT
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L127
https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L130
https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L133

The contract variables aToken, rewardsController, poolAddressesProviderRegistry must be immutable to save gas

IAToken public immutable aToken;
IRewardsController public immutable rewardsController;
IPoolAddressesProviderRegistry public immutable poolAddressesProviderRegistry;
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Apr 29, 2022
code423n4 added a commit that referenced this issue Apr 29, 2022
@code423n4
rotcivegaf issue #1
75aad8c
This was referenced Apr 30, 2022
Open
Open
@PierrickGT PierrickGT self-assigned this May 2, 2022
@PierrickGT PierrickGT added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label May 2, 2022
@PierrickGT
Copy link
Member

PR: pooltogether/aave-v3-yield-source#2

This was referenced May 2, 2022
Merged
Closed
Open
Open
Closed
Open
Open
Open
Open
Closed
Closed
@gititGoro
Copy link
Collaborator

Duplicate of #2

@gititGoro gititGoro marked this as a duplicate of #2 May 20, 2022
@gititGoro gititGoro added the duplicate This issue or pull request already exists label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierrickGT PierrickGT

Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PierrickGT @gititGoro @code423n4