Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #106

Open
code423n4 opened this issue May 19, 2022 · 1 comment
Open

Gas Optimizations #106

code423n4 opened this issue May 19, 2022 · 1 comment
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

https://github.com/aurafinance/aura-contracts-lite/blob/main/contracts/AuraLocker.sol#L309

uint256 reward = userData[_account][_rewardsToken].rewards;
if (reward > 0)

reward is uint256, use "if(reward!=0)" will save gas
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels May 19, 2022
code423n4 added a commit that referenced this issue May 19, 2022
@code423n4
zmj issue #106
50d2990
@0xMaharishi 0xMaharishi added the duplicate This issue or pull request already exists label May 25, 2022
@0xMaharishi
Copy link

valid but saving 4 gas? cmon

@dmvt dmvt removed the duplicate This issue or pull request already exists label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmvt @code423n4 @0xMaharishi