Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #107

Closed
code423n4 opened this issue May 19, 2022 · 1 comment
Closed

QA Report #107

code423n4 opened this issue May 19, 2022 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Outdated compiler

The pragma version used is pragma solidity ^0.8.11; but recently solidity released a new version with major fixes fixed, the minimum required version should be 0.8.14

Note Low was already sent by me, but this issue is new
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 19, 2022
code423n4 added a commit that referenced this issue May 19, 2022
@code423n4
0x1f8b issue #107
42cb5df
@0xMaharishi 0xMaharishi added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label May 25, 2022
This was referenced May 29, 2022
Merged
Open
@dmvt dmvt added the duplicate This issue or pull request already exists label Jul 7, 2022
@dmvt
Copy link
Collaborator

dmvt commented Jul 8, 2022 •
edited
Loading

Grouping this with the warden’s QA report, #83

@dmvt dmvt closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmvt @code423n4 @0xMaharishi