Gas Optimizations

[code423n4]

The contract : https://github.com/code-423n4/2022-05-aura/blob/main/contracts/Aura.sol at function checks if the msg.sender is the operator using if condition instead of modifier,
this consumes gas more than using a modifier

see :

function mint(address _to, uint256 _amount) external {
        require(totalSupply() != 0, "Not initialised");

        if (msg.sender != operator) {
            // dont error just return. if a shutdown happens, rewards on old system
            // can still be claimed, just wont mint cvx
            return;
        }

consumed :

gas	30114 gas
transaction cost	26186 gas 
execution cost	26186 gas 

---

Using :

modifier isOperator() {
    require(msg.sender == operator,"not operator");
}

function mint(address _to, uint256 _amount) isOperator external {
        require(totalSupply() != 0, "Not initialised");

       
        }

consumed :

gas	30113 gas
transaction cost	26185 gas 
execution cost	26185 gas 

[0xMaharishi]

Incorrect as we don't want to revert. Also, only saves ONE gas

[dmvt]

Technically accurate. Letting it stand, although the value is low to non-existent.