QA Report

[code423n4]

QA Report

Non-Critical Issues

Floating compiler versions

Non-library/interface files should use fixed compiler versions, not floating ones:

2022-05-aura/contracts/AuraPenaltyForwarder.sol:
   2:        pragma solidity ^0.8.11;

2022-05-aura/contracts/AuraMinter.sol:
   2:        pragma solidity ^0.8.11;

2022-05-aura/contracts/AuraMerkleDrop.sol:
   2:        pragma solidity ^0.8.11;

2022-05-aura/contracts/AuraVestedEscrow.sol:
   2:        pragma solidity ^0.8.11;

2022-05-aura/contracts/BalLiquidityProvider.sol:
   2:        pragma solidity ^0.8.11;

2022-05-aura/contracts/AuraBalRewardPool.sol:
   2:        pragma solidity ^0.8.11;

2022-05-aura/contracts/ExtraRewardsDistributor.sol:
   2:        pragma solidity ^0.8.11;

event is missing indexed fields

Each event should use three indexed fields if there are three or more fields:

2022-05-aura/convex-platform/contracts/contracts/ConvexMasterChef.sol:
  69:        event Deposit(address indexed user, uint256 indexed pid, uint256 amount);
  70:        event Withdraw(address indexed user, uint256 indexed pid, uint256 amount);
  71:        event RewardPaid(address indexed user,  uint256 indexed pid, uint256 amount);

  72:        event EmergencyWithdraw(
  73:                address indexed user,
  74:                uint256 indexed pid,
  75:                uint256 amount
  76:            );

2022-05-aura/convex-platform/contracts/contracts/Booster.sol:
  69:        event Deposited(address indexed user, uint256 indexed poolid, uint256 amount);
  70:        event Withdrawn(address indexed user, uint256 indexed poolid, uint256 amount);
  72:        event PoolAdded(address lpToken, address gauge, address token, address rewardPool, address stash, uint256 pid);
  78:        event FactoriesUpdated(address rewardFactory, address stashFactory, address tokenFactory);
  82:        event FeesUpdated(uint256 lockIncentive, uint256 stakerIncentive, uint256 earmarkIncentive, uint256 platformFee);
  84:        event FeeInfoUpdated(address feeDistro, address lockFees, address feeToken);

2022-05-aura/convex-platform/contracts/contracts/RewardFactory.sol:
  31:        event RewardPoolCreated(address rewardPool, uint256 _pid, address depositToken);
  32:        event TokenRewardPoolCreated(address rewardPool, address token, address mainRewards, address operator);

2022-05-aura/convex-platform/contracts/contracts/interfaces/IERC4626.sol:
  15:        event Deposit(
  16:                address indexed sender,
  17:                address indexed receiver,
  18:                uint256 assets,
  19:                uint256 shares
  20:            );

  24:        event Withdraw(
  25:                address indexed sender,
  26:                address indexed receiver,
  27:                uint256 assets,
  28:                uint256 shares
  29:            );

2022-05-aura/contracts/AuraMerkleDrop.sol:
  41:        event Claimed(address addr, uint256 amt, bool locked);

2022-05-aura/contracts/AuraVestedEscrow.sol:
  40:        event Claim(address indexed user, uint256 amount, bool locked);

2022-05-aura/contracts/AuraLocker.sol:
 127:        event RewardPaid(address indexed _user, address indexed _rewardsToken, uint256 _reward);
 128:        event Staked(address indexed _user, uint256 _paidAmount, uint256 _lockedAmount);
 129:        event Withdrawn(address indexed _user, uint256 _amount, bool _relocked);
 130:        event KickReward(address indexed _user, address indexed _kicked, uint256 _reward);

2022-05-aura/contracts/AuraBalRewardPool.sol:
  51:        event RewardPaid(address indexed user, uint256 reward, bool locked);

2022-05-aura/contracts/ExtraRewardsDistributor.sol:
  28:        event RewardAdded(address indexed token, uint256 indexed epoch, uint256 reward);
  29:        event RewardPaid(address indexed user, address indexed token, uint256 reward, uint256 index);
  30:        event RewardForfeited(address indexed user, address indexed token, uint256 index);